chore: add stack overflow warning for Visitor and VisitorMut #2068
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Oct 15, 2025
src/ast/visitor.rs
Outdated
| /// node and `post_visit_` methods are invoked after visiting all | ||
| /// children of the node. | ||
| /// | ||
| /// Important note: The `Break` type should be kept as small as possible to prevent |
There was a problem hiding this comment.
could we place the note on the documentation of Break instead? here for example
There was a problem hiding this comment.
Sure, moved the note.
src/ast/visitor.rs
Outdated
| /// node and `post_visit_` methods are invoked after visiting all | ||
| /// children of the node. | ||
| /// | ||
| /// Important note: The `Break` type should be kept as small as possible to prevent |
There was a problem hiding this comment.
could we place the note on the documentation of Break instead? here for example
iffyio
force-pushed
the
chore/visitor_caution
branch
from
03a2dc3 to
d92528c
Compare
iffyio
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our scenario, we set
Breaka customErrortype, with its size being around 100 bytes. This caused our stack space to be rapidly consumed during visitor recursion, and for more complex SQL queries, it even led to stack overflow.We solved this problem by boxing the Error.