Tsaucer/find window fn #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-J-Ward
approved these changes
Jul 4, 2024
andygrove
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #730.
Rationale for this change
The current fix is a work around for the
sumfunction. We have hard coded it to use the aggregate sum function as the built in function is removed. With this change, we can remove all other built in window functions without having to similarly encode work arounds.What changes are included in this PR?
This change will add a search order to attempt to find the correct function, by first looking through all registered window functions, then registered aggregate functions, then default aggregate functions, and finally the built in window functions.
Are there any user-facing changes?
None.