Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libprotobuf dep #527

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Conversation

jdye64
Copy link
Contributor

@jdye64 jdye64 commented Oct 26, 2023

Which issue does this PR close?

Closes #526

src/lib.rs Outdated Show resolved Hide resolved
conda/recipes/meta.yaml Outdated Show resolved Hide resolved
@andygrove andygrove merged commit da6c183 into apache:main Oct 26, 2023
16 checks passed
@jorisvandenbossche
Copy link
Member

With datafusion-substrait now being an optional feature, that also means that the datafusion python wheels will no longer include substrait support? Is there a way to still install it with pip?

@jdye64
Copy link
Contributor Author

jdye64 commented Dec 1, 2023

With datafusion-substrait now being an optional feature, that also means that the datafusion python wheels will no longer include substrait support? Is there a way to still install it with pip?

This is a good point I had not considered. Seems like we need to make sure at release time to specify that feature should be included. I think it is fine to always include substrait in the python wheels. I think the problem was mostly for 3rd party applications that are using ADP more like an SDK. Not sure on Andy's process for a release. @andygrove is there something I might need to commit/file change to enable that for each release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Substrait Rust Feature
4 participants