-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove libprotobuf dep #527
Conversation
…trait will be built for pytests when using pip
With |
This is a good point I had not considered. Seems like we need to make sure at release time to specify that feature should be included. I think it is fine to always include substrait in the python wheels. I think the problem was mostly for 3rd party applications that are using ADP more like an SDK. Not sure on Andy's process for a release. @andygrove is there something I might need to commit/file change to enable that for each release? |
Which issue does this PR close?
Closes #526