feature: Additional export methods #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simicd
commented
Feb 25, 2023
examples/export.py
Outdated
Comment on lines
50
to
52
| # export to Polars dataframe | ||
| polars_df = pl.DataFrame(df.to_arrow_table()) | ||
| assert polars_df.shape == (3, 2) |
There was a problem hiding this comment.
Do you think it's worthwhile introducing a to_polars() helper function?
There was a problem hiding this comment.
Yes, I think that would be great
There was a problem hiding this comment.
Thanks for the feedback - added to_polars() method & unit tests for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #234
Closes #235
Rationale for this change
Implement additional export functions and fix bug if datafusion dataframe is empty
What changes are included in this PR?
to_arrow_table(),to_pylist()andto_pydict()Are there any user-facing changes?
See above