Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce conda directory containing datafusion-dev.yaml conda enviro… #124

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

jdye64
Copy link
Contributor

@jdye64 jdye64 commented Jan 13, 2023

…nment file, conda build files for building and publishing packages to anaconda.org as well as supporting documentation updates to README.md

Which issue does this PR close?

Closes #122

Are there any user-facing changes?

There are developer facing changes. The README has been updated to reflect those changes in this PR.

…nment file, conda build files for building and publishing packages to anaconda.org as well as supporting documentation updates to README.md
```bash
pip install datafusion
# or
python -m pip install datafusion
```

### Conda
```bash
conda install -c conda-forge datafusion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who will update the conda-forge metadata for new releases ?
I.e. would it be possible that a new version of a-d-python is released, e.g. 0.9, and conda still installs 0.8 ?
If Conda does not fetch this info from PyPi then I expect users to file issues here about this and the a-d-p developers won't be able to help.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be the responsibility of the community to update conda-forge at release time. Let me add the logic in the release scripts and document that in this PR.

For what its worth there is an repo at https://anaconda.org/conda-forge/datafusion and I am trying to find out who owns that now so the proper permissions can be established

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be the responsibility of the community to update conda-forge at release time. Let me add the logic in the release scripts and document that in this PR.

For what its worth there is an repo at https://anaconda.org/conda-forge/datafusion and I am trying to find out who owns that now so the proper permissions can be established

I now have permissions for this repo and can add other PMC members

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jdye64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support creating arrow-datafusion-python conda environment
3 participants