Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #39 - Add .asf.yaml for asf-site #105

Closed
wants to merge 5 commits into from
Closed

Issue #39 - Add .asf.yaml for asf-site #105

wants to merge 5 commits into from

Conversation

martin-g
Copy link
Member

@martin-g martin-g commented Dec 5, 2022

Which issue does this PR close?

Issue #39 .

Rationale for this change

To auto-update the documentation whenever something is pushed to the asf-site branch.

What changes are included in this PR?

Adds publish section in .asf.yaml so that it publishes to https://arrow.apache.org/datafusion-python

Are there any user-facing changes?

No

@martin-g
Copy link
Member Author

martin-g commented Dec 5, 2022

Related-to: #104

@martin-g
Copy link
Member Author

martin-g commented Dec 5, 2022

@kou Please review!

@martin-g martin-g mentioned this pull request Dec 5, 2022
Merged
kou
kou reviewed Dec 6, 2022
View reviewed changes
.asf.yaml Outdated Show resolved Hide resolved
.asf.yaml Outdated
commits: [email protected]
issues: [email protected]
pullrequests: [email protected]
jira_options: link label worklog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this because we don't use Jira.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it!

.asf.yaml Outdated Show resolved Hide resolved
kou
kou approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou changed the base branch from asf-site to master December 6, 2022 08:25
@kou kou closed this Dec 6, 2022
@kou
Copy link
Member

kou commented Dec 6, 2022

Oh, sorry. This pull request was closed...
We need to put .asf.yaml to the default branch (master) not asf-site.
I changed the base branch to master then this pull request was closed...
Could you create one more pull request that uses master as the base branch?

@kou
Copy link
Member

kou commented Dec 6, 2022

Sorry... I was wrong...
We need to put .asf.yaml to asf-site... Could you create the same pull request again? Sorry...

https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Publishingabranchtoyourprojectwebsite

Note: although publishing the asf-site branch used to work without .asf.yaml being present, since May 2021 that file MUST be present at the root of the branch you wish to publish. for everything (including soft purging the CDN cache on updates) to work correctly.

@martin-g martin-g mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin-g @kou @andygrove