Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix Comet error message #544

Merged
merged 4 commits into from
Jun 10, 2024
Merged

feat: Fix Comet error message #544

merged 4 commits into from
Jun 10, 2024

Conversation

comphead
Copy link
Contributor

@comphead comphead commented Jun 8, 2024

Which issue does this PR close?

Closes #293 .

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@comphead comphead changed the title Fix error message feat: Fix Comet error message Jun 8, 2024
@comphead comphead requested a review from andygrove June 8, 2024 21:46
@andygrove
Copy link
Member

Thanks @comphead. LGTM. Could you also update this section in CometCastSuite:

            // We have to workaround https://github.com/apache/datafusion-comet/issues/293 here by
            // removing the "Execution error: " error message prefix that is added by DataFusion
            val cometMessage = cometException.getCause.getMessage.replace("Execution error: ", "")

Co-authored-by: Andy Grove <[email protected]>
@comphead comphead requested a review from andygrove June 10, 2024 19:20
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @comphead

@comphead comphead merged commit 351d0ff into apache:main Jun 10, 2024
43 checks passed
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
* fix error message


Co-authored-by: Andy Grove <[email protected]>

---------

Co-authored-by: Andy Grove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Execution error: " prefix from error messages from Rust
2 participants