Skip to content

chore: Fallback to Spark for windows functions #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 6 commits into from
Nov 8, 2025
Merged

chore: Fallback to Spark for windows functions #2726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e19f10e
chore: Fallback to Spark for Windows
comphead Nov 7, 2025
481b688
chore: Fallback to Spark for Windows
comphead Nov 7, 2025
7dccd13
chore: Fallback to Spark for windows
comphead Nov 7, 2025
d9dc391
chore: Fallback to Spark for windows
comphead Nov 7, 2025
928e223
chore: Fallback to Spark for windows
comphead Nov 8, 2025
926491c
chore: Fallback to Spark for windows
comphead Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,6 +1125,9 @@ object QueryPlanSerde extends Logging with CometExprShim {

case WindowExec(windowExpression, partitionSpec, orderSpec, child)
if CometConf.COMET_EXEC_WINDOW_ENABLED.get(conf) =>
withInfo(op, "Window expressions are not supported")
None
/*
val output = child.output

val winExprs: Array[WindowExpression] = windowExpression.flatMap { expr =>
Expand Down Expand Up @@ -1165,7 +1168,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
Some(builder.setWindow(windowBuilder).build())
} else {
None
}
} */

case aggregate: BaseAggregateExec
if (aggregate.isInstanceOf[HashAggregateExec] ||
Expand Down
2 changes: 1 addition & 1 deletion .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q12.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q12/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q20.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q20/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q36.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q36/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
6 changes: 3 additions & 3 deletions .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q47.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
: : +- Filter
: : +- Window
: : +- Filter
: : +- Window
: : +- Window [COMET: Window expressions are not supported]
: : +- CometColumnarToRow
: : +- CometSort
: : +- CometExchange
Expand Down Expand Up @@ -39,7 +39,7 @@
: : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
: +- BroadcastExchange
: +- Project
: +- Window
: +- Window [COMET: Window expressions are not supported]
: +- CometColumnarToRow
: +- CometSort
: +- CometExchange
Expand Down Expand Up @@ -71,7 +71,7 @@
: +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
+- BroadcastExchange
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
6 changes: 3 additions & 3 deletions spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q47/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
: : +- Filter
: : +- Window
: : +- Filter
: : +- Window
: : +- Window [COMET: Window expressions are not supported]
: : +- CometColumnarToRow
: : +- CometSort
: : +- CometExchange
Expand Down Expand Up @@ -39,7 +39,7 @@
: : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
: +- BroadcastExchange
: +- Project
: +- Window
: +- Window [COMET: Window expressions are not supported]
: +- CometColumnarToRow
: +- CometSort
: +- CometExchange
Expand Down Expand Up @@ -71,7 +71,7 @@
: +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
+- BroadcastExchange
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
6 changes: 3 additions & 3 deletions .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q49.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ CometColumnarToRow
: +- Filter
: +- Window
: +- Sort
: +- Window
: +- Window [COMET: Window expressions are not supported]
: +- CometColumnarToRow
: +- CometSort
: +- CometExchange
Expand Down Expand Up @@ -40,7 +40,7 @@ CometColumnarToRow
: +- Filter
: +- Window
: +- Sort
: +- Window
: +- Window [COMET: Window expressions are not supported]
: +- CometColumnarToRow
: +- CometSort
: +- CometExchange
Expand All @@ -67,7 +67,7 @@ CometColumnarToRow
+- Filter
+- Window
+- Sort
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
6 changes: 3 additions & 3 deletions spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q49/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ CometColumnarToRow
: +- Filter
: +- Window
: +- Sort
: +- Window
: +- Window [COMET: Window expressions are not supported]
: +- CometColumnarToRow
: +- CometSort
: +- CometExchange
Expand Down Expand Up @@ -40,7 +40,7 @@ CometColumnarToRow
: +- Filter
: +- Window
: +- Sort
: +- Window
: +- Window [COMET: Window expressions are not supported]
: +- CometColumnarToRow
: +- CometSort
: +- CometExchange
Expand All @@ -67,7 +67,7 @@ CometColumnarToRow
+- Filter
+- Window
+- Sort
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
6 changes: 3 additions & 3 deletions .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q51.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Filter
+- Window [COMET: Partitioning and sorting specifications must be the same.]
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand All @@ -9,7 +9,7 @@
:- CometSort
: +- CometColumnarExchange
: +- Project
: +- Window [COMET: Partitioning and sorting specifications must be the same.]
: +- Window [COMET: Window expressions are not supported]
: +- CometColumnarToRow
: +- CometSort
: +- CometExchange
Expand All @@ -33,7 +33,7 @@
+- CometSort
+- CometColumnarExchange
+- Project
+- Window [COMET: Partitioning and sorting specifications must be the same.]
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
6 changes: 3 additions & 3 deletions spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q51/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Filter
+- Window [COMET: Partitioning and sorting specifications must be the same.]
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand All @@ -9,7 +9,7 @@
:- CometSort
: +- CometColumnarExchange
: +- Project
: +- Window [COMET: Partitioning and sorting specifications must be the same.]
: +- Window [COMET: Window expressions are not supported]
: +- CometColumnarToRow
: +- CometSort
: +- CometExchange
Expand All @@ -33,7 +33,7 @@
+- CometSort
+- CometColumnarExchange
+- Project
+- Window [COMET: Partitioning and sorting specifications must be the same.]
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q53.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Filter
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q53/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Filter
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
6 changes: 3 additions & 3 deletions .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q57.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
: : +- Filter
: : +- Window
: : +- Filter
: : +- Window
: : +- Window [COMET: Window expressions are not supported]
: : +- CometColumnarToRow
: : +- CometSort
: : +- CometExchange
Expand Down Expand Up @@ -39,7 +39,7 @@
: : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.call_center
: +- BroadcastExchange
: +- Project
: +- Window
: +- Window [COMET: Window expressions are not supported]
: +- CometColumnarToRow
: +- CometSort
: +- CometExchange
Expand Down Expand Up @@ -71,7 +71,7 @@
: +- CometScan [native_iceberg_compat] parquet spark_catalog.default.call_center
+- BroadcastExchange
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
6 changes: 3 additions & 3 deletions spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q57/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
: : +- Filter
: : +- Window
: : +- Filter
: : +- Window
: : +- Window [COMET: Window expressions are not supported]
: : +- CometColumnarToRow
: : +- CometSort
: : +- CometExchange
Expand Down Expand Up @@ -39,7 +39,7 @@
: : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.call_center
: +- BroadcastExchange
: +- Project
: +- Window
: +- Window [COMET: Window expressions are not supported]
: +- CometColumnarToRow
: +- CometSort
: +- CometExchange
Expand Down Expand Up @@ -71,7 +71,7 @@
: +- CometScan [native_iceberg_compat] parquet spark_catalog.default.call_center
+- BroadcastExchange
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q63.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Filter
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q63/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Filter
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q70.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometColumnarExchange
Expand Down
2 changes: 1 addition & 1 deletion spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q70/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometColumnarExchange
Expand Down
2 changes: 1 addition & 1 deletion .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q86.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q86/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q89.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Filter
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q89/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Filter
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion .../tpcds-plan-stability/approved-plans-v1_4-spark3_5/q98.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ CometColumnarToRow
+- CometSort
+- CometColumnarExchange
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q98/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ CometColumnarToRow
+- CometSort
+- CometColumnarExchange
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometExchange
Expand Down
2 changes: 1 addition & 1 deletion .../tpcds-plan-stability/approved-plans-v1_4-spark4_0/q12.native_iceberg_compat/extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
TakeOrderedAndProject [COMET: ]
+- Project
+- Window
+- Window [COMET: Window expressions are not supported]
+- CometColumnarToRow
+- CometSort
+- CometColumnarExchange
Expand Down
Loading
Loading