-
Notifications
You must be signed in to change notification settings - Fork 246
Feat: bitmap_count impl and some refactoring #2518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2518 +/- ##
============================================
+ Coverage 56.12% 58.74% +2.61%
- Complexity 976 1452 +476
============================================
Files 119 148 +29
Lines 11743 13642 +1899
Branches 2251 2362 +111
============================================
+ Hits 6591 8014 +1423
- Misses 4012 4405 +393
- Partials 1140 1223 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Starting CI |
Thanks @comphead, but the test failures occurred due to DataFusion's lack of support for dictionary-encoded types. Cause: org.apache.comet.CometNativeException: Error from DataFusion: bitmap_count expects Binary/BinaryView/FixedSizeBinary/LargeBinary as argument, got Dictionary(Int32, Binary). |
Created a task: apache/datafusion#18058 |
Which issue does this PR close?
Part of: #2443
Rationale for this change
For the bitmap_count and read_side_padding functions, Spark uses a StaticInvoke wrapper. (https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/bitmapExpressions.scala#L85)
What changes are included in this PR?
How are these changes tested?
A new UT has been added.