chore: Refactor remaining predicate expression serde #2265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
Member
Author
|
@CuteChuanChuan fyi |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2265 +/- ##
============================================
+ Coverage 56.12% 57.80% +1.68%
- Complexity 976 1290 +314
============================================
Files 119 145 +26
Lines 11743 13363 +1620
Branches 2251 2373 +122
============================================
+ Hits 6591 7725 +1134
- Misses 4012 4381 +369
- Partials 1140 1257 +117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
comphead
reviewed
Aug 31, 2025
| import org.apache.comet.serde.ExprOuterClass.Expr | ||
| import org.apache.comet.serde.QueryPlanSerde._ | ||
|
|
||
| object CometNot extends CometExpressionSerde[Not] { |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2019
Rationale for this change
See #2019 for rationale.
Continues the work started in #2028 and moves the remaining predicate expressions out of QueryPlanSerde
What changes are included in this PR?
How are these changes tested?