fix: [Iceberg] Fix decimal corruption #1985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@hsiang-c fyi |
huaxingao
approved these changes
Jul 3, 2025
Contributor
|
Thanks @andygrove |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
============================================
+ Coverage 56.12% 58.19% +2.06%
- Complexity 976 1151 +175
============================================
Files 119 133 +14
Lines 11743 13037 +1294
Branches 2251 2420 +169
============================================
+ Hits 6591 7587 +996
- Misses 4012 4216 +204
- Partials 1140 1234 +94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hsiang-c
added a commit
to hsiang-c/datafusion-comet
that referenced
this pull request
Jul 3, 2025
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
We need to patch Iceberg source to specify
useDecimal128 = truein the Comet integration.This PR updates the 1.8.1 diff file within Comet to apply this fix.
We also need to fix this in Apache Iceberg repo.
What changes are included in this PR?
How are these changes tested?
Tested manually. The Iceberg integration tests that we run in Comet CI did not detect this bug.