Skip to content

minor: Refactor PhysicalPlanner::default() to avoid duplicate code #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

minor: Refactor PhysicalPlanner::default() to avoid duplicate code #1821

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6380de
Minor refactor to PhysicalPlanner::default() to avoid duplicate code
andygrove May 30, 2025
2566439
upmerge
andygrove Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions native/core/src/execution/planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,7 @@ pub struct PhysicalPlanner {

impl Default for PhysicalPlanner {
fn default() -> Self {
let session_ctx = Arc::new(SessionContext::new());

// register UDFs from datafusion-spark crate
session_ctx.register_udf(ScalarUDF::new_from_impl(SparkExpm1::default()));

Self {
exec_context_id: TEST_EXEC_CONTEXT_ID,
session_ctx,
}
Self::new(Arc::new(SessionContext::new()))
Copy link
Member Author

@andygrove andygrove May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that Self::new will register the UDF:

    pub fn new(session_ctx: Arc<SessionContext>) -> Self {
        // register UDFs from datafusion-spark crate
        session_ctx.register_udf(ScalarUDF::new_from_impl(SparkExpm1::default()));
        Self {
            exec_context_id: TEST_EXEC_CONTEXT_ID,
            session_ctx,
        }
    }

}
}

Expand Down
Loading