Skip to content

chore: Reimplement ShuffleWriterExec using interleave_record_batch #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 9 commits into from
Apr 1, 2025
Merged

chore: Reimplement ShuffleWriterExec using interleave_record_batch #1511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f66924d
Reimplement ShuffleWriterExec using interleave_record_batch
Kontinuation Mar 11, 2025
ae6b0f3
Coalesce small batches into larger batches when shuffle writing singl…
Kontinuation Mar 18, 2025
3a001ad
buffer writes to shuffle files and spill files
Kontinuation Mar 21, 2025
ef79ab5
Reimplemented single partition shuffle write
Kontinuation Mar 26, 2025
7ad9dfc
Clean up
Kontinuation Mar 27, 2025
6ec846d
Address review comments
Kontinuation Mar 28, 2025
aab2943
Address review comments
Kontinuation Apr 1, 2025
a78ac09
Fix timer in write and flush to measure nothing but write_all and flush
Kontinuation Apr 1, 2025
f2e76d8
Measure more disk writing operations
Kontinuation Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion native/core/src/execution/planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,7 +1214,7 @@ impl PhysicalPlanner {
}?;

let shuffle_writer = Arc::new(ShuffleWriterExec::try_new(
Arc::clone(&child.native_plan),
Self::wrap_in_copy_exec(Arc::clone(&child.native_plan)),
partitioning,
codec,
writer.output_data_file.clone(),
Expand Down
Loading
Loading