Skip to content

fix: cast timestamp to decimal is unsupported #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 4 commits into from
Jan 14, 2025
Merged

fix: cast timestamp to decimal is unsupported #1281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
122ca46
fix: cast timestamp to decimal is unsupported
wForget Jan 14, 2025
a8a4da9
fix style
wForget Jan 14, 2025
53a92ea
revert test name and mark as ignore
wForget Jan 14, 2025
90fc866
add comment
wForget Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion spark/src/main/scala/org/apache/comet/expressions/CometCast.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ object CometCast {
Compatible()
case DataTypes.StringType => Compatible()
case DataTypes.DateType => Compatible()
case _: DecimalType => Compatible()
case _ => Unsupported
}
}
Expand Down
6 changes: 4 additions & 2 deletions spark/src/test/scala/org/apache/comet/CometCastSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,8 +838,10 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
castTest(generateTimestamps(), DataTypes.DoubleType)
}

test("cast TimestampType to DecimalType(10,2)") {
castTest(generateTimestamps(), DataTypes.TimestampType)
Copy link
Member Author

@wForget wForget Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andygrove This test case introduced in #356 looks incorrect. Could you please take a look?

ignore("cast TimestampType to DecimalType(10,2)") {
// https://github.com/apache/datafusion-comet/issues/1280
// Native cast invoked for unsupported cast from Timestamp(Microsecond, Some("Etc/UTC")) to Decimal128(10, 2)
castTest(generateTimestamps(), DataTypes.createDecimalType(10, 2))
}

test("cast TimestampType to StringType") {
Expand Down
Loading