[comet-parquet-exec] fix: Set scan implementation choice via environment variable #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
approved these changes
Jan 8, 2025
Member
|
Thanks @parthchandra. LGTM but now needs a rebase. |
viirya
approved these changes
Jan 8, 2025
parthchandra
force-pushed
the
comet-parquet-exec
branch
from
4832fcb to
cac8ead
Compare
Contributor
Author
|
@andygrove rebased |
andygrove
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to switch scan implementation types during development by setting the environment variable
NATIVE_SCAN_IMPL= {native | native_full | native_recordbatch }Default remains
native_full