[comet-parquet-exec] Disable DPP in stability tests when full native scan is enabled #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthchandra
reviewed
Jan 7, 2025
| @@ -263,11 +263,13 @@ trait CometPlanStabilitySuite extends DisableAdaptiveExecutionSuite with TPCDSBa | |||
| classLoader = Thread.currentThread().getContextClassLoader) | |||
| // Disable char/varchar read-side handling for better performance. | |||
| withSQLConf( | |||
| // Comet does not yet support DPP yet | |||
| // https://github.com/apache/datafusion-comet/issues/121 | |||
| SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "false", | |||
Contributor
There was a problem hiding this comment.
Should we do this only if the parquet implementation is native_full or native_recordbatch ?
parthchandra
approved these changes
Jan 7, 2025
Contributor
parthchandra
left a comment
parthchandra
left a comment
There was a problem hiding this comment.
lgtm. minor comment
viirya
approved these changes
Jan 7, 2025
andygrove
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Stability tests were failing becaue the POC native scan code does not support DPP.
What changes are included in this PR?
How are these changes tested?