chore: extract math_funcs expressions to folders based on spark grouping #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
approved these changes
Jan 5, 2025
andygrove
changed the title
Member
|
@rluvaton I managed to get most of these PRs merged. Would you have time to help fix merge conflicts on this one? |
This comment was marked as resolved.
This comment was marked as resolved.
# Conflicts: # native/spark-expr/src/comet_scalar_funcs.rs # native/spark-expr/src/lib.rs # native/spark-expr/src/scalar_funcs.rs # native/spark-expr/src/scalar_funcs/hash_expressions.rs
Member
Author
|
@andygrove Can you please start the CI? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
=============================================
+ Coverage 34.72% 57.46% +22.74%
+ Complexity 992 961 -31
=============================================
Files 117 114 -3
Lines 45046 11173 -33873
Branches 9901 2137 -7764
=============================================
- Hits 15640 6421 -9219
+ Misses 26253 3639 -22614
+ Partials 3153 1113 -2040 ☔ View full report in Codecov by Sentry. |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
…ing (apache#1219) * extract math_funcs expressions to folders based on spark grouping * fix merge conflicts and move chr to `string_funcs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from:
Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark
ExpressionDescriptiongrouppropertyWhat changes are included in this PR?
just reorder files and extract functions there are no logic changes
How are these changes tested?
Existing tests