Skip to content

fix: fix missing explanation for then branch in case when #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viirya merged 1 commit into from
Dec 27, 2024
Merged

fix: fix missing explanation for then branch in case when #1200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1745,7 +1745,7 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim
exprToProtoInternal(elements._1, inputs)
})
val thenSeq = branches.map(elements => {
allBranches = allBranches :+ elements._1
allBranches = allBranches :+ elements._2
Copy link
Member

@viirya viirya Dec 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice catch. Thanks.

Is it possible to add a test for this?

exprToProtoInternal(elements._2, inputs)
})
assert(whenSeq.length == thenSeq.length)
Expand Down
Loading