fix: [comet-parquet-exec] Use RDD partition index #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Use RDD partition index * fix * fix * fix
andygrove
changed the title
viirya
commented
Nov 25, 2024
Comment on lines
+1039
to
+1045
| // If reaching leaf node, reset `firstNativeOp` to true | ||
| // because it will start a new block in next iteration. | ||
| if (op.children.isEmpty) { | ||
| firstNativeOp = true | ||
| } | ||
|
|
||
| newPlan |
Member
Author
There was a problem hiding this comment.
Here this is the main diff that we don't have in main branch. Because native scan now is a real "native" operator, once we encounter it when transforming down, we need to reset firstNativeOp flag.
parthchandra
approved these changes
Dec 2, 2024
Member
Author
|
Thanks @parthchandra @andygrove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
This cherry-picks the fix #1112 to
comet-parquet-execfeature branch to fix failed testlimit (cartesian product)inCometExecSuite.Rationale for this change
What changes are included in this PR?
How are these changes tested?