Skip to content

Conversation

@liukun4515
Copy link
Contributor

Which issue does this PR close?

Closes #88

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@liukun4515 liukun4515 requested a review from andygrove July 20, 2022 05:13
@andygrove
Copy link
Member

I'm curious why we would want to delete the Cargo.lock. Isn't it best practice to have that checked in for applications?

@thinkharderdev
Copy link
Contributor

I'm curious why we would want to delete the Cargo.lock. Isn't it best practice to have that checked in for applications?

@andygrove It should get folded into the Cargo.lock in the workspace root. But you're right we should run the workspace build in this PR to add the cli deps to the root lock file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why not include the ballista-cli in the member of workspace

3 participants