CURATOR-728: Not issue ZooKeeper::create if possible in ZkPaths::mkdirs #518
Conversation
| @@ -282,28 +282,29 @@ public static void mkdirs(ZooKeeper zookeeper, String path, boolean makeLastNode | |||
| */ | |||
| public static void mkdirs( | |||
| ZooKeeper zookeeper, | |||
| String path, | |||
| final String path, | |||
There was a problem hiding this comment.
Params are by default not be mutated. I suppose we don't need final to params.
|
Hmm, I pushed to |
kezhuw
force-pushed
the
CURATOR-728-ZkPaths-mkdirs-not-issue-create-if-possible
branch
2 times, most recently
from
ed2d3ae to
0fb6f3a
Compare
| @@ -224,7 +224,7 @@ | |||
| <dependency>org.apache.curator:curator-recipes</dependency> | |||
| <dependency>org.apache.curator:curator-client</dependency> | |||
| </dependenciesToScan> | |||
| <excludedGroups>master</excludedGroups> | |||
| <excludedGroups>master,ZOOKEEPER-2590</excludedGroups> | |||
There was a problem hiding this comment.
ZOOKEEPER-2590 is never landed in 3.7 though it is tagged with 3.7.3.
| @@ -31,7 +31,7 @@ | |||
| <artifactId>curator-test-zk38</artifactId> | |||
|
|
|||
| <properties> | |||
| <zookeeper-38-version>3.8.3</zookeeper-38-version> | |||
| <zookeeper-38-version>3.8.4</zookeeper-38-version> | |||
There was a problem hiding this comment.
ZOOKEEPER-2590 is landed in 3.8.4.
| fail("Expected NoAuthException when not authorized to read new node grandparent"); | ||
| } catch (KeeperException.NoAuthException noAuthException) { | ||
| assertEquals(noAuthException.getPath(), "/bat"); |
There was a problem hiding this comment.
The old test reported NoAuth on creating /bat/bost. I think this is not the target CURATOR-715 trying to assert.
`ZkPaths::mkdir("/bar/foo")` will not run into `NoAuthException` if
"/bar/foo" exists, and we have `READ` permission to "/bar/foo" but not
`CREATE` permission to "/bar".
kezhuw
force-pushed
the
CURATOR-728-ZkPaths-mkdirs-not-issue-create-if-possible
branch
from
0fb6f3a to
ba387f2
Compare
kezhuw
deleted the
CURATOR-728-ZkPaths-mkdirs-not-issue-create-if-possible
branch
|
@kezhuw thank you for fixing this. It helps to unblock our upgrade to Zookeeper 3.9.3. Do you know when will be the next release that include this patch ? |
…rs (apache#518) `ZkPaths::mkdir("/bar/foo")` will not run into `NoAuthException` if "/bar/foo" exists, and we have `READ` permission to "/bar/foo" but not `CREATE` permission to "/bar".
|
@yang-wei There is no schedule for next release yet. You could post mail to dev mailing list to let the community know. |
ZkPaths::mkdir("/bar/foo")will not run intoNoAuthExceptionif"/bar/foo" exists, and we have
READpermission to "/bar/foo" but notCREATEpermission to "/bar".