CURATOR-715. bottom up existence check for mkdirs #506
+61
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would vote up the fix , this is real blocker to anybody upgrading zookeeper to version with fix for ZOOKEEPER-2590 |
eolivelli
approved these changes
Sep 11, 2024
|
Hopefully we can include this in the next release, looking for a second reviewer |
Thank you @eolivelli! I've just pushed code style fix after executing |
kezhuw
approved these changes
Sep 12, 2024
|
@pfcoperez Merged. Thank you for your contribution! |
tisonkun
reviewed
Sep 12, 2024
tisonkun
changed the title
|
Thank you @eolivelli @kezhuw and @tisonkun for your reviews 🙇 Do you have any plans of releasing before the end of the year? |
|
Please ask on [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles the problem reported in https://issues.apache.org/jira/browse/CURATOR-715.
Namely, that for ZooKeeper trees where upper nodes have restricted READ ACLs, it is not possible to use
creatingParentsIfNeededwithout changing the ACLs.This is because the implementation prior to this patch iterated from root node to the newly created one, checking existence of all intermediate nodes.
This patch changes that approach from top-down to bottom-up and the first ancestor that exists is where the validation stops thus avoiding
existschecks on the higher nodes with more restricted access.This is only relevant since https://issues.apache.org/jira/browse/ZOOKEEPER-2590