Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, maybe cannot deleteChildren completely when multi-client delete concurrently #234

Closed
wants to merge 1 commit into from

Conversation

he7g
Copy link
Contributor

@he7g he7g commented Aug 11, 2017

No description provided.

@Randgalt
Copy link
Member

Please review https://cwiki.apache.org/confluence/display/CURATOR/Submitting+Pull+Requests

  • There must be a JIRA Issue created for your change
  • Create a git branch with the same name as the Issue

@Randgalt
Copy link
Member

Also, I don't know what the need for this is. ZKPaths is an internal utility and the Curator code that uses it already ignores the exception.

@he7g
Copy link
Contributor Author

he7g commented Aug 12, 2017

use curatorFramework.delete().deletingChildrenIfNeeded().forPath(path), this sync api doesn't ignore the NoNodeException, causes the rest of children nodes will not be deleted perhaps.

zookeeper.getChildren(path, null) maybe throw NoNodeException, if the path doesn't exist.

@he7g he7g changed the title Fix, maybe cannot deleteChildren completely when multi-client delete concurrently CURATOR-430 Aug 12, 2017
@he7g he7g changed the title CURATOR-430 Fix, maybe cannot deleteChildren completely when multi-client delete concurrently Aug 12, 2017
@he7g
Copy link
Contributor Author

he7g commented Aug 12, 2017

see #235, please

@he7g he7g closed this Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants