Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update deps, add Node 20 to CI #57

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Mar 25, 2024

Platforms affected

All

Motivation and Context

Update some dependencies, but very minimally. This package appears to still support Node 14, and I don't want to drop that and have to do a major version bump right now, so I pretty much just ran npm audit fix 😕

Description

  • Fix GitHub Actions warnings about old actions versions
  • Resolve npm security audit warnings
  • Added Node 20.x to CI matrix

Testing

Unit tests all pass in CI.

Checklist

  • I've run the tests to see all new and existing tests pass

This appears to still support Node 14, so I did not pull in any breaking
changes.
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.98%. Comparing base (9dce9f1) to head (ff2d018).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   27.98%   27.98%           
=======================================
  Files           6        6           
  Lines         218      218           
=======================================
  Hits           61       61           
  Misses        157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue dpogue merged commit fd273f5 into apache:master Mar 25, 2024
12 checks passed
@dpogue dpogue deleted the deps-202403 branch March 25, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants