Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CB-10882 : Plugin Media - "cordova-plugin-media" 2.2.0 seem have a "position" bug with mediaSound.getCurrentPosition method #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThillaiganeshChan
Copy link

…ave a "position" bug with mediaSound.getCurrentPosition method.

Added a Check for Recorder also in 'getCurrentPositionAudio'

…ave a "position" bug with mediaSound.getCurrentPosition method
@sonicwong
Copy link

When I play a mp3 in 2.2.0 @ ios.
No sound come out. I am not sure it related to this fix or not.

@vladimir-kotikov
Copy link
Member

@ThillaiganeshChan, please update this PR's title to use the correct JIRA ticket number. The title for CB-10822 is "Deduplicate common logic for storing modules metadata in cordova_plugins.js" and is not related to this change

@ghenry22
Copy link
Contributor

ghenry22 commented Apr 8, 2016

@sonicwong it's not related to this as this PR is related to getPosition for recordings.

There was however, recently a PR merged that fixed playback of local files where no protocol prefix was set.

I would suggest trying the latest version of the plugin installed directly from github with:

cordova plugin add https://github.com/apache/cordova-plugin-media.git

@ThillaiganeshChan ThillaiganeshChan changed the title Fix for CB-10822 : Plugin Media - "cordova-plugin-media" 2.2.0 seem h… Fix for CB-10822 : Plugin Media - "cordova-plugin-media" 2.2.0 seem have a "position" bug with mediaSound.getCurrentPosition method Apr 8, 2016
@ThillaiganeshChan ThillaiganeshChan changed the title Fix for CB-10822 : Plugin Media - "cordova-plugin-media" 2.2.0 seem have a "position" bug with mediaSound.getCurrentPosition method Fix for CB-10882 : Plugin Media - "cordova-plugin-media" 2.2.0 seem have a "position" bug with mediaSound.getCurrentPosition method Apr 19, 2016
@bau720123
Copy link

bau720123 commented Apr 29, 2016

hi @ThillaiganeshChan and @vladimir-kotikov
I am the bug reporter
is there anything update ? or ...
https://issues.apache.org/jira/browse/CB-10882

@cordova-qa
Copy link

Cordova CI Build has one or more failures.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Mac Link Link Link

@sarangan12
Copy link
Contributor

Let there be tests

@cordova-qa
Copy link

Cordova CI Build has one or more failures.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Mac Link Link Link

@bau720123
Copy link

hello guys
this bug have been reported three months ago
https://issues.apache.org/jira/browse/CB-10882
is there any update or ... ???

@ghenry22
Copy link
Contributor

Just reading through your steps to reproduce in Jira and wanted to check where you are seeing the problem.

First you make a recording (this seems to work).

You then call getCurrentPosition().

Before calling getCurrentPosition(), have you stopped the recording, saved it and then created a new media object with the recording as SRC, called media.play() and then getCurrentPosition()?

I am going to do some testing and have a look at it, I just want to be really clear about where the problem is.

@bau720123
Copy link

bau720123 commented Jun 13, 2016

hi @ghenry22,thanks your reply

in "cordova-plugin-media" 2.2.0
yes,Before calling getCurrentPosition(), I stop the recording,after that,use getCurrentPosition()

but in "cordova-plugin-media" 2.3.0,I can't reproduce it,because it seem appear another problem
https://issues.apache.org/jira/browse/CB-11418

you can try 2.2.0 or 2.3.0,you will know what I mean

@bau720123
Copy link

well...@ghenry22
7 days passed
is there any unclear or anything that I should explain once again ?

@bau720123
Copy link

2 months passed
anything wrong ?

@bau720123
Copy link

bau720123 commented Sep 23, 2016

really sad...
https://issues.apache.org/jira/browse/CB-11867
this is a critical bug!but Cordova team Disregard it for a long time...

@ThillaiganeshChan way still not solve the problem
4deef09

@jcesarmobile
Copy link
Member

Pull Requests are welcome

@bau720123
Copy link

fixed by myself...

@jcesarmobile
Copy link
Member

how did you fix it?

@bau720123
Copy link

bau720123 commented Sep 26, 2016

hi @jcesarmobile
mediaRec.stopRecord();
if(navigator.userAgent.match(/iPad|iPhone|iPod/i)) { mediaRecord.release(); //otherwise,it will crash immediately }
if(navigator.userAgent.match(/Android/i)) { //do nothing,if use "release" method too,it will cause "record" method fail}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants