-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for CB-10882 : Plugin Media - "cordova-plugin-media" 2.2.0 seem have a "position" bug with mediaSound.getCurrentPosition method #87
base: master
Are you sure you want to change the base?
Conversation
…ave a "position" bug with mediaSound.getCurrentPosition method
When I play a mp3 in 2.2.0 @ ios. |
@ThillaiganeshChan, please update this PR's title to use the correct JIRA ticket number. The title for CB-10822 is "Deduplicate common logic for storing modules metadata in |
@sonicwong it's not related to this as this PR is related to getPosition for recordings. There was however, recently a PR merged that fixed playback of local files where no protocol prefix was set. I would suggest trying the latest version of the plugin installed directly from github with: cordova plugin add https://github.com/apache/cordova-plugin-media.git |
hi @ThillaiganeshChan and @vladimir-kotikov |
Let there be tests |
hello guys |
Just reading through your steps to reproduce in Jira and wanted to check where you are seeing the problem. First you make a recording (this seems to work). You then call getCurrentPosition(). Before calling getCurrentPosition(), have you stopped the recording, saved it and then created a new media object with the recording as SRC, called media.play() and then getCurrentPosition()? I am going to do some testing and have a look at it, I just want to be really clear about where the problem is. |
hi @ghenry22,thanks your reply in "cordova-plugin-media" 2.2.0 but in "cordova-plugin-media" 2.3.0,I can't reproduce it,because it seem appear another problem you can try 2.2.0 or 2.3.0,you will know what I mean |
well...@ghenry22 |
2 months passed |
really sad... @ThillaiganeshChan way still not solve the problem |
Pull Requests are welcome |
fixed by myself... |
how did you fix it? |
hi @jcesarmobile |
…ave a "position" bug with mediaSound.getCurrentPosition method.
Added a Check for Recorder also in 'getCurrentPositionAudio'