Skip to content

Quick CI fixes #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brody4hire merged 5 commits into from
Jul 31, 2018
Merged

Quick CI fixes #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb245ec
.travis.yml add blank lines
Jul 31, 2018
e75fe14
.appveyor.yml add npm i & add eslint to test
Jul 31, 2018
a464ea6
.travis.yml quick fixes
Jul 31, 2018
81f1437
README.md add AppVeyor CI & Travis CI details
Jul 31, 2018
07d9a99
Skip Android 6.0 on Travis CI (for now)
Jul 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ install:
- node --version
- npm install -g cordova-paramedic@https://github.com/apache/cordova-paramedic.git
- npm install -g cordova
- npm install

build: off

test_script:
- npm run eslint
- cordova-paramedic --config pr\%PLATFORM% --plugin . %JUST_BUILD%
93 changes: 54 additions & 39 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
sudo: false

addons:
jwt:
secure: TZ88IEvAw1bsWPWxvDzXdpi2NK0i3PN4hG15+vDpIt6wXGVPknjxuXWJeLj7TqBpAIvP7XDfS8ZvHVPLe7fe8oOchZPLuiDw9VVIk6cnHjE6wpoavdGc/1mDJ3Bi4PDcHwRUr5ng5spYQqqlTwcECkH/q7iPgudiFM6rlOlGRyA=

env:
global:
- SAUCE_USERNAME=snay
- TRAVIS_NODE_VERSION="4.2"

matrix:
include:
- env: PLATFORM=browser-chrome
Expand All @@ -16,10 +19,11 @@ matrix:
os: linux
language: node_js
node_js: '4.2'
- env: PLATFORM=browser-safari
os: linux
language: node_js
node_js: '4.2'
# TBD SKIP for now:
# - env: PLATFORM=browser-safari
# os: linux
# language: node_js
# node_js: '4.2'
- env: PLATFORM=browser-edge
os: linux
language: node_js
Expand All @@ -29,11 +33,15 @@ matrix:
osx_image: xcode7.3
language: node_js
node_js: '4.2'
- env: PLATFORM=ios-10.0
os: osx
osx_image: xcode7.3
language: node_js
node_js: '4.2'
# TBD SKIP for now:
# - env: PLATFORM=ios-10.0
# os: osx
# osx_image: xcode7.3
# language: node_js
# node_js: '4.2'
# FUTURE TBD:
Copy link
Member

@janpio janpio Oct 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this should never be in code, only in issues.

# - env: PLATFORM=ios-11.4
# ...
- env: PLATFORM=android-4.4
os: linux
language: android
Expand All @@ -44,36 +52,41 @@ matrix:
- platform-tools
- tools
- build-tools-26.0.2
- env: PLATFORM=android-5.1
os: linux
language: android
jdk: oraclejdk8
android:
components:
- tools
- platform-tools
- tools
- build-tools-26.0.2
- env: PLATFORM=android-6.0
os: linux
language: android
jdk: oraclejdk8
android:
components:
- tools
- platform-tools
- tools
- build-tools-26.0.2
- env: PLATFORM=android-7.0
os: linux
language: android
jdk: oraclejdk8
android:
components:
- tools
- platform-tools
- tools
- build-tools-26.0.2
# TBD SKIP for now:
# - env: PLATFORM=android-5.1
# os: linux
# language: android
# jdk: oraclejdk8
# android:
# components:
# - tools
# - platform-tools
# - tools
# - build-tools-26.0.2
# - env: PLATFORM=android-6.0
# os: linux
# language: android
# jdk: oraclejdk8
# android:
# components:
# - tools
# - platform-tools
# - tools
# - build-tools-26.0.2
# - env: PLATFORM=android-7.0
# os: linux
# language: android
# jdk: oraclejdk8
# android:
# components:
# - tools
# - platform-tools
# - tools
# - build-tools-26.0.2
# FUTURE TBD:
Copy link
Member

@janpio janpio Oct 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this should never be in code, only in issues.

# - env: PLATFORM=android-8.?
# ...

before_install:
- rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm
&& git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh && nvm
Expand All @@ -86,8 +99,10 @@ before_install:
- git clone https://github.com/apache/cordova-paramedic /tmp/paramedic && pushd /tmp/paramedic
&& npm install && popd
- npm install -g cordova

install:
- npm install

script:
- npm test
- node /tmp/paramedic/main.js --config pr/$PLATFORM --plugin $(pwd) --shouldUseSauce
Expand Down
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ description: Open an in-app browser window.
|AppVeyor|Travis CI|
|:-:|:-:|
|[![Build status](https://ci.appveyor.com/api/projects/status/github/apache/cordova-plugin-inappbrowser?branch=master)](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-plugin-inappbrowser)|[![Build Status](https://travis-ci.org/apache/cordova-plugin-inappbrowser.svg?branch=master)](https://travis-ci.org/apache/cordova-plugin-inappbrowser)|
|npm install|npm install|
Copy link
Member

@janpio janpio Oct 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

|eslint|eslint|
||browser (chrome, firefox, edge)|
||iOS (9.3) on Xcode 7.3|
||Android (4.4)|

# cordova-plugin-inappbrowser

Expand Down