fix(android): enable download functionality with Android Q #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old code
kpatfln
force-pushed
the
download-api-android-q
branch
from
a22d77a
to
d8991bc
Compare
|
@erisu Removed the whitelist code - it wasn't necessary. Thanks! |
breautek
reviewed
Sep 9, 2021
Remove old code [Android] Add support for Android API 30 and above
kpatfln
changed the title
|
@erisu Hi - I've completed the suggested changes. How does it look? :) |
breautek
approved these changes
Sep 24, 2021
erisu
changed the title
erisu
approved these changes
Sep 24, 2021
dpalou
pushed a commit
to moodlemobile/cordova-plugin-file-transfer
that referenced
this pull request
Jan 14, 2022
jcaron23
added a commit
to Netisse/cordova-plugin-file-transfer-tests
that referenced
this pull request
Jun 15, 2023
…pache#310)" This reverts commit cab8b46.
jcaron23
added a commit
to Netisse/cordova-plugin-file-transfer-tests
that referenced
this pull request
Jun 15, 2023
…oid Q (apache#310)"" This reverts commit c5ab8b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
On Android Q and above, the download functionality does not function.
Description
This change enables use of FileOutputStream to save files into the download folder.
Testing
Without the changes, Android Q will fail to download, while on Android P and below it will work fine.
With the changes, Android Q and above will have no problems with downloads.
Issues Resolved
#300
#291
Checklist
(platform)if this change only applies to one platform (e.g.(android))