Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass project config.xml path to platform's prepare #751

Merged
merged 1 commit into from
Mar 15, 2019

Commits on Mar 15, 2019

  1. Pass project config.xml path to platform's prepare

    Currently we're passing in an already-constructed ConfigParser instance
    as part of the fake projectInfo object, but the problem is that it's
    constructed with the version of cordova-common depended on by
    *cordova-lib* as opposed to the version of cordova-common depended on by
    the *platform*. By passing the path in, we can construct the
    ConfigParser at the Platform API level, using the correct version.
    
    In the meantime, for compatibility reasons, we have to keep passing in a
    ConfigParser instance, and the Platform API needs to handle the case
    where rootConfigXml is undefined and it needs to fetch the path out of
    the existing ConfigParser instance and then overwrite it with a newly
    constructed ConfigParser.
    
    We should at some point look into making this "root project info" object
    a class in cordova-common so that we can document what it's expected to
    contain and rely on that both here and in the platforms.
    dpogue committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    2469fd1 View commit details
    Browse the repository at this point in the history