cordova run --list --device fails for Virtualhere devices (fixes #458)

[regiMario]

Platforms affected

iOS

What does this PR do?

I'm using Virtualhere (https://www.virtualhere.com/home) for developing remotely.
While Safari and Xcode do see the device after connecting via Virtualhere, cordova does not.
The attached patch remedies the issue in [email protected]

What testing has been done on this change?

Manual testing with virtualhere devices as well as regular USB devices

Checklist

• Reported an issue in the JIRA database
• Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
• Added automated test coverage as appropriate for this change.

closes #458

[dpogue]

Just a note that the test failures are coming from these tests that are checking to see if a command matching /system_profiler/ was invoked. You can update those to check for /ioreg/ and they should pass.

[regiMario]

I tried running the tests before i uploaded and got this far.
`[mario@mac13dev ~/github/cordova-ios]$ npm test

[email protected] test /Users/mario/github/cordova-ios
npm run unit-tests && npm run test:component && npm run objc-tests && npm run e2e-tests

[email protected] unit-tests /Users/mario/github/cordova-ios
jasmine --config=tests/spec/unit.json

DEPRECATION: Setting throwOnExpectationFailure directly on Env is deprecated, please use the oneFailurePerSpec option in configure
DEPRECATION: Setting randomizeTests directly is deprecated, please use the random option in configure
internal/modules/cjs/loader.js:582
throw err;
^

Error: Cannot find module 'cordova-common'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:580:15)
at Function.Module._load (internal/modules/cjs/loader.js:506:25)
at Module.require (internal/modules/cjs/loader.js:636:17)
at require (internal/modules/cjs/helpers.js:20:18)
at Object. (/Users/mario/github/cordova-ios/tests/spec/unit/Api.spec.js:22:21)
at Module._compile (internal/modules/cjs/loader.js:688:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
at Module.load (internal/modules/cjs/loader.js:598:32)
at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
at Function.Module._load (internal/modules/cjs/loader.js:529:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 4
npm ERR! [email protected] unit-tests: jasmine --config=tests/spec/unit.json
npm ERR! Exit status 4
npm ERR!
npm ERR! Failed at the [email protected] unit-tests script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?
npm ERR! Test failed. See above for more details.
[mario@mac13dev ~/github/cordova-ios]$ npm -g list --depth=0
/usr/local/lib
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]`

[codecov-io]

Codecov Report

Merging #461 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   74.29%   74.29%           
=======================================
  Files          12       12           
  Lines        1564     1564           
=======================================
  Hits         1162     1162           
  Misses        402      402

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ebfbd...8ad9dc5. Read the comment docs.

[janpio]

@regiMario Thanks for fixing the tests. Could you please report your problems running the tests in a new issue, with the output you already posted? This should be investigated separately. Thanks.

[dpogue]

This looks good to me.

For those wondering, ioreg is a lower-level call than system_profiler, but they serve similar purposes as far as I can tell and there are several StackOverflow posts about macOS scripts where people are encouraged to switch to ioreg to get the info they're looking for.

[shazron]

Tested with the nightly. Detects my device ok