-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug alert() iOS #1121
base: master
Are you sure you want to change the base?
fix bug alert() iOS #1121
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
=======================================
Coverage 74.86% 74.86%
=======================================
Files 13 13
Lines 1723 1723
=======================================
Hits 1290 1290
Misses 433 433 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me. I'm not sure it needs to be a class method rather than an instance method, but the idea seems good
@@ -160,4 +159,29 @@ - (void)webViewDidClose:(WKWebView*)webView | |||
} | |||
|
|||
|
|||
+ (UIViewController *)topViewController { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for this to be a static method on CDVWebViewUIDelegate
rather than an instance method used with [self topViewController]
? It looks like all uses of it are within the CDVWebViewUIDelegate
class
Closes apacheGH-1120. Closes apacheGH-1121. Closes apacheGH-1429.
Closes apacheGH-1120. Closes apacheGH-1121. Closes apacheGH-1429.
Platforms affected
iOS
Motivation and Context
issues #1120
Description
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)