cordova-windows 6+: Windows 10 default #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodycj
reviewed
May 1, 2019
janpio
commented
May 6, 2019
| <preference name="windows-target-version" value="8.1" /> | ||
| <preference name="Windows.Universal" value="10.0.10240.0" /> |
There was a problem hiding this comment.
From my understanding of https://github.com/apache/cordova-windows/blob/8cc627b8f5fb4a0959c4ef7a5994a4f358215fd6/template/cordova/lib/ConfigParser.js#L103-L170 this could never actually work and was probably a misunderstanding how the preference actually worked (what was written in this line is the fallback that is used if nothing is supplied here). Lines 398 and 399 show two working examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Windows docs for what is reality since cordova-windows 6.x