Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Bump android gradle plugin to 3.6.0 #962

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

breautek
Copy link
Contributor

Platforms affected

Android

Motivation and Context

Upgrades android gradle plugin to 3.6.0.

afaik there are no issues that are dependant on this change, but this is usually considered a breaking change, so it would be great to be included in the 9.0.0 release.

Description

Updated the framework and the two android test projects version pins.

Testing

ran npm test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek requested review from erisu and timbru31 April 25, 2020 02:22
@breautek breautek added this to the 9.0.0 milestone Apr 25, 2020
@timbru31
Copy link
Member

Release Notes are over here: https://developer.android.com/studio/releases/gradle-plugin#3-6-0

@breautek breautek merged commit e86b211 into apache:master Apr 25, 2020
@breautek breautek deleted the android-gradle-plugin branch April 25, 2020 17:34
@erisu
Copy link
Member

erisu commented Apr 27, 2020

3.6.3 I believe is actually the latest release from April.

https://mvnrepository.com/artifact/com.android.tools.build/gradle/3.6.3

@breautek
Copy link
Contributor Author

breautek commented Apr 27, 2020

I used https://developer.android.com/studio/releases/gradle-plugin to determine the latest, they don't mention 3.6.3 O.o

3.6.x changes shouldn't be breaking anyway, so if we need it should be easy to update at anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants