Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: synced androidx gradle versions to the same version as the android test #959

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Apr 15, 2020

Platforms affected

Android

Motivation and Context

Fixes androidx test versions, who was still on gradle 4 and android gradle plugin 3.5.3, inconsistent with its android test sibling.

Description

Upgrade gradle version pins

Testing

Ran npm test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Apr 15, 2020

Codecov Report

Merging #959 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #959   +/-   ##
=======================================
  Coverage   65.53%   65.53%           
=======================================
  Files          21       21           
  Lines        1828     1828           
=======================================
  Hits         1198     1198           
  Misses        630      630           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566262c...dc9a56c. Read the comment docs.

@breautek breautek mentioned this pull request Apr 15, 2020
5 tasks
@breautek breautek requested a review from erisu April 15, 2020 23:56
@breautek breautek merged commit 1ce2b6b into apache:master Apr 16, 2020
@breautek breautek deleted the gradle-versions-update branch April 16, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants