-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use es6 class #911
Conversation
Codecov Report
@@ Coverage Diff @@
## master #911 +/- ##
=========================================
Coverage ? 65.28%
=========================================
Files ? 21
Lines ? 1815
Branches ? 0
=========================================
Hits ? 1185
Misses ? 630
Partials ? 0
Continue to review full report at Codecov.
|
Please edit the PR to use the github keyword syntax for linking PRs to issues. e.g: "Fixes #905" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed though it and most looked OK.
I think there was one change that was not correct. Please confirm.
Resolves #905
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)