Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use es6 class #911

Merged
merged 3 commits into from
Feb 1, 2020
Merged

refactor: use es6 class #911

merged 3 commits into from
Feb 1, 2020

Conversation

ShukantPal
Copy link
Contributor

@ShukantPal ShukantPal commented Jan 30, 2020

Resolves #905

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5cf38cf). Click here to learn what that means.
The diff coverage is 57.69%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #911   +/-   ##
=========================================
  Coverage          ?   65.28%           
=========================================
  Files             ?       21           
  Lines             ?     1815           
  Branches          ?        0           
=========================================
  Hits              ?     1185           
  Misses            ?      630           
  Partials          ?        0
Impacted Files Coverage Δ
bin/templates/cordova/lib/retry.js 100% <ø> (ø)
bin/templates/cordova/lib/android_sdk.js 100% <ø> (ø)
bin/templates/cordova/lib/emulator.js 89.83% <100%> (ø)
...lates/cordova/lib/config/GradlePropertiesParser.js 76.66% <100%> (ø)
bin/templates/cordova/lib/build.js 31.61% <12.5%> (ø)
bin/templates/cordova/lib/utils.js 17.85% <17.85%> (ø)
bin/templates/cordova/lib/check_reqs.js 51.2% <25%> (ø)
bin/templates/cordova/lib/prepare.js 34.53% <37.5%> (ø)
...n/templates/cordova/lib/builders/ProjectBuilder.js 71.97% <39.53%> (ø)
bin/lib/utils.js 75% <75%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf38cf...df6fe78. Read the comment docs.

@breautek
Copy link
Contributor

Please edit the PR to use the github keyword syntax for linking PRs to issues.

https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords

e.g: "Fixes #905"

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed though it and most looked OK.
I think there was one change that was not correct. Please confirm.

bin/templates/cordova/Api.js Outdated Show resolved Hide resolved
@erisu erisu changed the title ES6 class refactoring refactor: use es6 class Jan 31, 2020
@erisu erisu merged commit c56cd4d into apache:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update codebase to ES6 syntax
4 participants