Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add androidx support #901

Merged
merged 2 commits into from
Jan 27, 2020
Merged

feat: add androidx support #901

merged 2 commits into from
Jan 27, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 20, 2020

Motivation, Context, & Description

Adds AndroidX Support
Removes the need for the cordova-plugin-androidx plugin.

closes: #565

Testing

  • npm t
  • cordova platform add
  • cordova build android

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added this to the 9.0.0 milestone Jan 20, 2020
@erisu erisu requested a review from dpogue January 20, 2020 00:00
@erisu erisu force-pushed the feat/androidx branch 3 times, most recently from c61d70b to e01e18c Compare January 20, 2020 01:21
@codecov-io
Copy link

codecov-io commented Jan 20, 2020

Codecov Report

Merging #901 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
- Coverage   66.17%   66.03%   -0.15%     
==========================================
  Files          19       19              
  Lines        1839     1843       +4     
==========================================
  Hits         1217     1217              
- Misses        622      626       +4
Impacted Files Coverage Δ
...lates/cordova/lib/config/GradlePropertiesParser.js 76.66% <ø> (ø) ⬆️
bin/templates/cordova/lib/prepare.js 35.11% <0%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef742e...377c512. Read the comment docs.

@erisu erisu force-pushed the feat/androidx branch 2 times, most recently from 559da96 to 0a90447 Compare January 20, 2020 02:43
Copy link

@knight9999 knight9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be just fine.
By the way, because the test code /test/app/buld.gradle uses old com.android.support:appcompat-v7, it is better to add new test app for Android X (using androidx.appcompat:appcompat-v7).

@erisu erisu requested a review from knight9999 January 21, 2020 06:54
@erisu
Copy link
Member Author

erisu commented Jan 21, 2020

@knight9999 I added the AndroidX Java unit tests.

@erisu erisu force-pushed the feat/androidx branch 2 times, most recently from 125cf79 to 0ec5d0f Compare January 21, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

androidx
3 participants