-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add androidx support #901
Conversation
c61d70b
to
e01e18c
Compare
Codecov Report
@@ Coverage Diff @@
## master #901 +/- ##
==========================================
- Coverage 66.17% 66.03% -0.15%
==========================================
Files 19 19
Lines 1839 1843 +4
==========================================
Hits 1217 1217
- Misses 622 626 +4
Continue to review full report at Codecov.
|
559da96
to
0a90447
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be just fine.
By the way, because the test code /test/app/buld.gradle
uses old com.android.support:appcompat-v7
, it is better to add new test app for Android X
(using androidx.appcompat:appcompat-v7
).
@knight9999 I added the AndroidX Java unit tests. |
125cf79
to
0ec5d0f
Compare
Motivation, Context, & Description
Adds AndroidX Support
Removes the need for the
cordova-plugin-androidx
plugin.closes: #565
Testing
npm t
cordova platform add
cordova build android
Checklist