-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kotlin support #896
Conversation
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.41% 66.27% -0.15%
==========================================
Files 19 19
Lines 1849 1853 +4
==========================================
Hits 1228 1228
- Misses 621 625 +4
Continue to review full report at Codecov.
|
I went ahead and created a new Kotlin support PR so we can quickly apply all the changes and improvements to get Kotlin prepared and released hopefully in the next day or 2. Per your change request in the previous PR, I have:
NOTICE:
If these are to be updated, it should be taken care of in a separate PR
|
@timbru31 I just added the Kotlin source set as well, per your change request's overview comment. The only thing I was not sure is if it was necessary to wrap that behind a flag too. |
IMO no need for a flag for adding the src/main/kotlin folder. Note that currently all plugin source files will end up in src/main/java because there's no special handling to detect kotlin files. |
c66388c
to
7e5443d
Compare
@@ -19,16 +19,16 @@ | |||
// Top-level build file where you can add configuration options common to all sub-projects/modules. | |||
|
|||
buildscript { | |||
ext.kotlin_version = '1.3.50' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the Android Studio default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if you create a blank "No Activity" project in Android Studio, it has in the project's build.gradle
:
ext.kotlin_version = '1.3.50'
7e5443d
to
0f61780
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine.
I can run Kotlin code successfully with this PR.
18f9fe3
to
99ee5d0
Compare
Motivation and Context
To finish off the change requests and close out PR #441
closes: #441
Description
What this PR does:
EnableKotlin
toGradlePluginKotlinEnabled
(Default:false
)GradlePluginKotlinCodeStyle
(Default:official
)GradlePluginKotlinVersion
(Default:1.3.50
)kotlin-android-extensions
plugin as well whenGradlePluginKotlinEnabled
istrue
compile
toimplementation
Testing
npm t
Checklist