Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and fix promise handling in specs #787

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Simplify and fix promise handling in specs #787

merged 1 commit into from
Jul 17, 2019

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Jul 17, 2019 •
edited
Loading

A replica of apache/cordova-lib#619 for this repository.

@raphinesse raphinesse requested a review from erisu July 17, 2019 09:21
erisu
erisu approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raphinesse raphinesse merged commit ad742ec into apache:master Jul 17, 2019
@raphinesse raphinesse deleted the spec-promise-handling branch July 17, 2019 12:56
@raphinesse raphinesse mentioned this pull request Oct 30, 2019
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphinesse @erisu