-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore more Gradle build artifacts in Android project #632
Conversation
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
=======================================
Coverage 64.66% 64.66%
=======================================
Files 18 18
Lines 1817 1817
=======================================
Hits 1175 1175
Misses 642 642 Continue to review full report at Codecov.
|
That PR description is a bit light on information. Why wasn't this in there before? Why should this be in now? Are those new files? Or was this just missed before? There is also a merge conflict that has to be resolved. |
…to ignore-more-build-artifacts
I just added the info to the description and resolved the conflict. I hope it is clear now, would be happy to answer any other questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this matches a popular gitignore suggestion for Gradle:
https://github.com/github/gitignore/blob/master/Gradle.gitignore
And /app/build
seems to be "new" because of the move of the project into app
, in some earlier time it was probably all generated in /build
.
Thanks @janpio! I didn't see that link before, just added a couple more artifacts. |
Umm, do we actually have those? Otherwise those are not really necessary to include. But well, it's merged already. |
I hope we can get this in before the next major release for Cordova 9 (apache/cordova#10).
P..S. These artifacts are generated by Gradle when the user does
cordova build android
orcordova run android
.