Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore more Gradle build artifacts in Android project #632

Merged
merged 4 commits into from
Feb 11, 2019

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jan 18, 2019

I hope we can get this in before the next major release for Cordova 9 (apache/cordova#10).

P..S. These artifacts are generated by Gradle when the user does cordova build android or cordova run android.

@codecov-io
Copy link

codecov-io commented Jan 18, 2019

Codecov Report

Merging #632 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #632   +/-   ##
=======================================
  Coverage   64.66%   64.66%           
=======================================
  Files          18       18           
  Lines        1817     1817           
=======================================
  Hits         1175     1175           
  Misses        642      642

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a98708...b263d0a. Read the comment docs.

@janpio
Copy link
Member

janpio commented Feb 9, 2019

That PR description is a bit light on information.

Why wasn't this in there before? Why should this be in now? Are those new files? Or was this just missed before?

There is also a merge conflict that has to be resolved.

@brodycj brodycj changed the title Ignore more Gradle build artifacts in Android project [WIP] Ignore more Gradle build artifacts in Android project Feb 10, 2019
@brodycj brodycj changed the title [WIP] Ignore more Gradle build artifacts in Android project Ignore more Gradle build artifacts in Android project Feb 11, 2019
@brodycj
Copy link
Contributor Author

brodycj commented Feb 11, 2019

I just added the info to the description and resolved the conflict. I hope it is clear now, would be happy to answer any other questions.

Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this matches a popular gitignore suggestion for Gradle:
https://github.com/github/gitignore/blob/master/Gradle.gitignore

And /app/build seems to be "new" because of the move of the project into app, in some earlier time it was probably all generated in /build.

@brodycj
Copy link
Contributor Author

brodycj commented Feb 11, 2019

Thanks @janpio! I didn't see that link before, just added a couple more artifacts.

@brodycj brodycj merged commit e99c145 into apache:master Feb 11, 2019
@brodycj brodycj deleted the ignore-more-build-artifacts branch February 11, 2019 19:58
@janpio
Copy link
Member

janpio commented Feb 11, 2019

Umm, do we actually have those? Otherwise those are not really necessary to include. But well, it's merged already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants