Fix requirements error messages for JDK 8 #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodycj
requested review from
janpio,
dpogue,
raphinesse,
erisu and
jcesarmobile
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
======================================
Coverage 64.7% 64.7%
======================================
Files 18 18
Lines 1816 1816
======================================
Hits 1175 1175
Misses 641 641
Continue to review full report at Codecov.
|
brodycj
changed the title
rtpHarry
added a commit
to rtpHarry/ionic-docs
that referenced
this pull request
Jan 24, 2019
It's not just recommended, it's required. I tried this today and there is a flat out version check in the source code that locks it to JDK8. Also, added https to the download link as the site runs on that now. FYI if you don't have much time to research this then here is some help: I also worked with the cordova-android team to clarify this in their error messages and it's been accepted: - apache/cordova-android#619 - apache/cordova-android#620 If you look in the files changed the version check is just around those changed lines.
mhartington
pushed a commit
to ionic-team/ionic-docs
that referenced
this pull request
Feb 4, 2019
) It's not just recommended, it's required. I tried this today and there is a flat out version check in the source code that locks it to JDK8. Also, added https to the download link as the site runs on that now. FYI if you don't have much time to research this then here is some help: I also worked with the cordova-android team to clarify this in their error messages and it's been accepted: - apache/cordova-android#619 - apache/cordova-android#620 If you look in the files changed the version check is just around those changed lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the error message in response to discussion in #618.
I am not a super JDK 8 expert, would appreciate some feedback if my proposal looks good or not.
P.S. Fixed in another place in response to #619 (comment).