(android) add missing cast for cdvMinSdkVersion #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
=======================================
Coverage 61.98% 61.98%
=======================================
Files 17 17
Lines 1978 1978
Branches 369 369
=======================================
Hits 1226 1226
Misses 752 752Continue to review full report at Codecov.
|
janpio
reviewed
Nov 14, 2018
| @@ -117,7 +117,7 @@ if (ext.cdvReleaseSigningPropertiesFile == null && file('../release-signing.prop | |||
| // Cast to appropriate types. | |||
| ext.cdvBuildMultipleApks = cdvBuildMultipleApks == null ? false : cdvBuildMultipleApks.toBoolean(); | |||
| ext.cdvVersionCodeForceAbiDigit = cdvVersionCodeForceAbiDigit == null ? false : cdvVersionCodeForceAbiDigit.toBoolean(); | |||
| ext.cdvMinSdkVersion = cdvMinSdkVersion == null ? defaultMinSdkVersion : cdvMinSdkVersion | |||
| ext.cdvMinSdkVersion = cdvMinSdkVersion == null ? defaultMinSdkVersion : Integer.parseInt('' + cdvMinSdkVersion) | |||
There was a problem hiding this comment.
Some kind of recasting. This is code that was done in bf327f3 but got lost somehow.
There was a problem hiding this comment.
To be cast the value to a string if it was an integer before
There was a problem hiding this comment.
Ah, Integer.parseInt won't like to get an Int already?
brodycj
pushed a commit
to brodycj/cordova-android
that referenced
this pull request
Nov 14, 2018
brodycj
pushed a commit
to brodycj/cordova-android
that referenced
this pull request
Nov 14, 2018
brodycj
pushed a commit
to brodycj/cordova-android
that referenced
this pull request
Nov 15, 2018
brodycj
pushed a commit
to brodycj/cordova-android
that referenced
this pull request
Nov 16, 2018
brodycj
pushed a commit
to brodycj/cordova-android
that referenced
this pull request
Nov 16, 2018
brodycj
pushed a commit
to brodycj/cordova-android
that referenced
this pull request
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist