Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete check for JellyBean (GH-534) #544

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Nov 11, 2018

to work properly on Android Pie

was introduced in dc0bfeb (CB-11828)

Not needed since Android JellyBean (4.0-4.3) is no longer supported ref: https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#requirements-and-support

Credit goes to pradiv-kumar for raising the issue in #534 and proposing the original solution in #535.

Note that cordova.js should be regenerated by cordova-coho as described in: https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md

I would like to get this change into 7.1.x as well.

Resolves #534
Closes #535

to work properly on Android Pie

was introduced in dc0bfeb (CB-11828)

Resolves apache#534

Co-authored-by: <[email protected]>
Co-authored-by: Christopher J. Brody <[email protected]>
@codecov-io
Copy link

codecov-io commented Nov 11, 2018

Codecov Report

Merging #544 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #544   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files          17       17           
  Lines        1975     1975           
  Branches      367      367           
=======================================
  Hits         1222     1222           
  Misses        753      753

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da5374...a09594f. Read the comment docs.

@brodycj brodycj merged commit e31596f into apache:master Nov 12, 2018
@brodycj brodycj deleted the gh-534-remove-check branch November 12, 2018 17:07
brodycj pushed a commit to brodycj/cordova-android that referenced this pull request Nov 14, 2018
to work properly on Android Pie

was introduced in dc0bfeb (CB-11828)

Resolves apache#534

Co-authored-by: <[email protected]>
Co-authored-by: Christopher J. Brody <[email protected]>
brodycj pushed a commit to brodycj/cordova-android that referenced this pull request Nov 16, 2018
to work properly on Android Pie

was introduced in dc0bfeb (CB-11828)

Resolves apache#534

Co-authored-by: <[email protected]>
Co-authored-by: Christopher J. Brody <[email protected]>
brodycj pushed a commit to brodycj/cordova-android that referenced this pull request Nov 16, 2018
to work properly on Android Pie

was introduced in dc0bfeb (CB-11828)

Resolves apache#534

Co-authored-by: <[email protected]>
Co-authored-by: Christopher J. Brody <[email protected]>
@brodycj brodycj mentioned this pull request Nov 16, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants