Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect default sdk version issue fix #495

Merged

Conversation

Darshan-Chauhan
Copy link
Contributor

@Darshan-Chauhan Darshan-Chauhan commented Sep 12, 2018

This PR fixes issue of incorrect default sdk version

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Resolves #489

Copy link
Contributor

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right

@brodycj brodycj merged commit cfa58a5 into apache:master Sep 12, 2018
@brodycj
Copy link
Contributor

brodycj commented Sep 12, 2018

The change looks right, thanks. I edited the description to update the checklist and automatically close #489 as resolved.

brodycj pushed a commit that referenced this pull request Sep 12, 2018
as followup to GH-495
brodycj pushed a commit that referenced this pull request Sep 12, 2018
brodycj pushed a commit that referenced this pull request Sep 12, 2018
brodycj pushed a commit to brodycj/cordova-android that referenced this pull request Nov 14, 2018
brodycj pushed a commit to brodycj/cordova-android that referenced this pull request Nov 16, 2018
brodycj pushed a commit to brodycj/cordova-android that referenced this pull request Nov 16, 2018
brodycj pushed a commit to brodycj/cordova-android that referenced this pull request Nov 16, 2018
@brodycj brodycj mentioned this pull request Nov 16, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect default min SDK version ternary in build.gradle
2 participants