-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect default sdk version issue fix #495
Merged
brodycj
merged 1 commit into
apache:master
from
Darshan-Chauhan:incorrect-default-sdk-version
Sep 12, 2018
Merged
Incorrect default sdk version issue fix #495
brodycj
merged 1 commit into
apache:master
from
Darshan-Chauhan:incorrect-default-sdk-version
Sep 12, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodycj
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right
The change looks right, thanks. I edited the description to update the checklist and automatically close #489 as resolved. |
brodycj
pushed a commit
to brodycj/cordova-android
that referenced
this pull request
Nov 14, 2018
as followup to apacheGH-495
brodycj
pushed a commit
to brodycj/cordova-android
that referenced
this pull request
Nov 16, 2018
as followup to apacheGH-495
brodycj
pushed a commit
to brodycj/cordova-android
that referenced
this pull request
Nov 16, 2018
brodycj
pushed a commit
to brodycj/cordova-android
that referenced
this pull request
Nov 16, 2018
as followup to apacheGH-495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue of incorrect default sdk version
Checklist
Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.Added automated test coverage as appropriate for this change.Resolves #489