Device: Add unit tests and remove Q #462
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
What does this PR do?
The main point of this PR is to increase test coverage of
device.js
. It's gone from 0% to 100% coverage. :)Since I was going through
device.js
and figuring out how it works, I figured it was a good time to replace Q with native promises, as mentioned in CB-14158. I hope this is OK!What testing has been done on this change?
Checklist