-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-14165 : (android) Fix for device still connecting issues #457
Conversation
Add error message checking for device still connecting issues
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
- Coverage 52.06% 52.03% -0.04%
==========================================
Files 17 17
Lines 1694 1695 +1
Branches 311 312 +1
==========================================
Hits 882 882
- Misses 812 813 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you very much for this fix! 🙇♂️ |
Keep waiting for emulator when connection fails with "device still connecting" error
Keep waiting for emulator when connection fails with "device still connecting" error
This comment has been minimized.
This comment has been minimized.
This fix doesn't seem to be included in the latest release 7.1.1 which I would expect since the fix was done Jun 25th and the release Jul 12th, any particular reason for this? I really need this one. |
The release process of 7.1.1 was started Jun 19, 2018, which is a few days before this was merged into master. If you really need it, you can either install from |
Platforms affected
Android (Emulator)
What does this PR do?
Add fix for 'device still connecting' problem when using android emulator
What testing has been done on this change?
launching cordova emulate android
Checklist