Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit log event instead of logging directly #452

Merged
merged 1 commit into from
Jun 16, 2018
Merged

Emit log event instead of logging directly #452

merged 1 commit into from
Jun 16, 2018

Conversation

raphinesse
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #452 into master will increase coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   44.24%   44.27%   +0.03%     
==========================================
  Files          17       17              
  Lines        1693     1694       +1     
  Branches      311      311              
==========================================
+ Hits          749      750       +1     
  Misses        944      944
Impacted Files Coverage Δ
...in/templates/cordova/lib/builders/GradleBuilder.js 20.75% <50%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 472ab62...671c214. Read the comment docs.

dpogue
dpogue approved these changes Jun 16, 2018
View reviewed changes
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raphinesse raphinesse merged commit 2c3db19 into apache:master Jun 16, 2018
@raphinesse raphinesse deleted the remove-log branch June 16, 2018 18:08
@brodycj brodycj mentioned this pull request Jun 21, 2018
Merged
2 tasks
brodycj pushed a commit to brodycj/cordova-android that referenced this pull request Jun 21, 2018
@raphinesse
Emit log event instead of logging directly (apache#452)
1cfac12
brodycj pushed a commit to brodycj/cordova-android that referenced this pull request Jun 21, 2018
@raphinesse
Emit log event instead of logging directly (apache#452)
fe428d1 
in builder scripts
brodycj pushed a commit to brodycj/cordova-android that referenced this pull request Jul 4, 2018
@raphinesse
Emit log event instead of logging directly (apache#452)
9344b3e 
in builder scripts
brodycj pushed a commit to brodycj/cordova-android that referenced this pull request Jul 10, 2018
@raphinesse
Emit log event instead of logging directly (apache#452)
09d1a2a 
in builder scripts
brodycj pushed a commit that referenced this pull request Jul 11, 2018
@raphinesse
Emit log event instead of logging directly (#452)
9f33b0b 
in builder scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpogue dpogue dpogue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raphinesse @codecov-io @dpogue