Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Native test namespace refactor #1595

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

breautek
Copy link
Contributor

Platforms affected

Android Tests

Motivation and Context

#1539 forgot to refactor the native test

With the newer AGP version, specifying the package id inside AndroidManifest.xml is deprecated and should be defined in the gradle file under android.namespace

Solves:

package="org.apache.cordova.unittests" found in source AndroidManifest.xml: /development/cordova/breautek/cordova-android/test/androidx/app/src/main/AndroidManifest.xml.
Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated.
Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here: https://developer.android.com/studio/build/configure-app-module#set-namespace
This migration can be done automatically using the AGP Upgrade Assistant, please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.

Description

Removed package from AndroidManifest.xml test project.
Add namespace to it's gradle file.

Testing

Ran npm test.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek added this to the 12.0.0 milestone Apr 14, 2023
@breautek breautek requested a review from erisu April 14, 2023 02:01
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Merging #1595 (33895e7) into master (a9d4d4e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1595   +/-   ##
=======================================
  Coverage   71.82%   71.82%           
=======================================
  Files          23       23           
  Lines        1796     1796           
=======================================
  Hits         1290     1290           
  Misses        506      506           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erisu erisu merged commit 3a9c87d into apache:master Apr 14, 2023
@breautek breautek deleted the fix/test-namespace branch April 14, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants