CB-8201 Add support for auth dialogs into Cordova Android #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @param handler The HTTP auth handler. | ||
| */ | ||
| public void setHttpAuthRequestHandler(HttpAuthRequestHandler handler) { |
There was a problem hiding this comment.
If there's no direct reason to add this to CordovaActivity, I'd prefer it not added. CordovaActivity has a lot of symbols in it already, and they a little bit just add noise.
|
Addressed all CR notes, @agrieve could you please take a look |
|
Rebased on top of master branch |
| * @return Return True if there is a plugin which will resolve this auth challenge, otherwise False | ||
| * | ||
| */ | ||
| public Boolean onReceivedHttpAuthRequest(CordovaWebView view, ICordovaHttpAuthHandler handler, String host, String realm) { |
There was a problem hiding this comment.
Unless you want this to be tri-state, then "Boolean" should be "boolean". I don't see the need for tristate, so go with "boolean"
|
Just the one nit-pick, then looks good to me! Feel free to just squash and commit it yourself :) |
|
Done. @agrieve thx for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CB-8201
Makes it possible to provide custom pluggabble logic to process auth challenge (for example by installing corresponding plugin, sample implementation: https://github.com/msopentech/cordova-plugin-auth-dialog).
Motivation
If you load some resource which requires authentication using android default browser default login dialog appears, but if you try to load the same resource using cordova app then no dialog is shown for user and request is failed w/ 401 Unauthorized. So Currently apps have to provide own JS logic to show web based auth dialog.
It will be great if Cordova Android offers special functionality (in core or via special interface plugin developers can extend) to automatically show native auth dialog. This is extremely useful in corpnet scenarios where all resources requires user to be authenticated.