Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AndroidManifest): explicitly define the activity attribute android:exported #1372

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 28, 2021

Motivation and Context

Explicitly define the android:exported attribute on the Activty within the AndroidManifest.

Previously, this attribute did not need to be explicitly defined but start in Android 12 it will need to be.

Warning: If an activity, service, or broadcast receiver uses intent filters and doesn't have an explicitly-declared value for android:exported, your app can't be installed on a device that runs Android 12 or higher.

It is safe to add this to the current major as it does not introduce a breaking change.

Description

Adds the android:exported="true" to the activity attribute

Testing

  • build test with build-tools 30.0.3
  • build test with build-tools 31.0.0

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu requested review from dpogue and breautek October 28, 2021 04:53
@erisu erisu added this to the 10.1.2 milestone Oct 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #1372 (a6bafb7) into master (05e3e3c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1372   +/-   ##
=======================================
  Coverage   73.15%   73.15%           
=======================================
  Files          21       21           
  Lines        1643     1643           
=======================================
  Hits         1202     1202           
  Misses        441      441           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e3e3c...a6bafb7. Read the comment docs.

@erisu erisu merged commit a1ed1c0 into apache:master Oct 28, 2021
@erisu erisu deleted the feat/explicit-define-android-exported branch October 28, 2021 08:29
@apache apache locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants