refactor: use target SDK of built APK to determine best emulator #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1267 +/- ##
==========================================
- Coverage 71.48% 71.15% -0.34%
==========================================
Files 21 21
Lines 1645 1650 +5
==========================================
- Hits 1176 1174 -2
- Misses 469 476 +7 ☔ View full report in Codecov by Sentry. |
erisu
approved these changes
Jul 12, 2021
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
…che#1267) * refactor(emulator): require emulatorId in emulator.run * refactor: use effective targetSdk to find best emulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This reduces usage of
check_reqs.get_targetsince that function only considersconfig.xmlto find the target SDK and moreover relies on the script location to findconfig.xml(which has to change if we want to run the script from node_modules; also see #1265).Description
When looking for the best emulator image to run an APK on, the target SDK of that APK is determined by running
apkanalyzer manifest target-sdk.apkanalyzeris part of the Android SDK Tools since Revision 26.1.1 (September 2017).Testing
cordova run