Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump [email protected] #1262

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 6, 2021

Motivation, Context & Description

Bump AndroidX AppCompat to 1.3.0. Using the new centralized configuration defaults.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #1262 (ce9bd5b) into master (180a1a3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   71.62%   71.62%           
=======================================
  Files          21       21           
  Lines        1653     1653           
=======================================
  Hits         1184     1184           
  Misses        469      469           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180a1a3...ce9bd5b. Read the comment docs.

@jcesarmobile
Copy link
Member

Where do you check latest versions available?
I can't see it here
https://mvnrepository.com/artifact/androidx.appcompat/appcompat?repo=google

@erisu
Copy link
Member Author

erisu commented Jul 6, 2021

@jcesarmobile lets hold off on this one.

From the link you provided it only mentions 1.3.0-rc01.

Some reason Android Studio suggests me to upgrade to 1.3.0, but it didnt say anything about rc01.

From their docs, it seems that 1.3.0 exists but I dont know where it is being pulled from. Maybe from google() and not mavenCentral().

https://developer.android.com/jetpack/androidx/releases/appcompat#1.3.0

@erisu erisu marked this pull request as draft July 6, 2021 15:36
@erisu erisu changed the title feat: bump [email protected] [WIP] feat: bump [email protected] Jul 6, 2021
@erisu
Copy link
Member Author

erisu commented Jul 6, 2021

@erisu
Copy link
Member Author

erisu commented Jul 6, 2021

Actually from your link, it seems to also be listed under the scijava-public tab.

I am not sure what to do with this PR.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scijava-public packages are in a different location (http://maven.scijava.org/content/repositories/public/) than regular google packages (https://maven.google.com/), but yeah, it's published correctly on the later, so I guess that's ok and might just be some error on the mvnrepository site.

I've set the version to 1.3.0 and it gets downloaded without problems, so I guess it's ok

@erisu erisu changed the title [WIP] feat: bump [email protected] feat: bump [email protected] Jul 6, 2021
@erisu erisu marked this pull request as ready for review July 6, 2021 16:14
@erisu erisu merged commit 422ce4f into apache:master Jul 7, 2021
@erisu erisu deleted the feat/bump-appcompat branch July 7, 2021 02:17
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants